Possibly fixed multiple listener addition

hal-core/src/se/hal/intf/HalAbstractController.java

@@ -60,6 +60,7 @@ public interface HalAbstractController {
 
     /**
      * Add a listener to the controller that will receive all device reports from registered devices.
+     * Multiple calls with the same listener should only add register the listener once any subsequent calls should be ignored.
      */
     void addListener(HalDeviceReportListener listener);
 

hal-core/src/se/hal/intf/HalAbstractControllerManager.java

@@ -135,7 +135,7 @@ public abstract class HalAbstractControllerManager<T extends HalAbstractControll
 
     /**
      * Will return a singleton controller instance of the given class.
-     * If a instance does not exist yet the a new instance will be allocated
+     * If a instance does not exist yet then a new instance will be allocated
      * depending on if the controller is ready thorough the {@link HalAbstractController#isAvailable()} method.
      *
      * @param clazz     is the class of the wanted object instance wanted
@@ -167,8 +167,10 @@ public abstract class HalAbstractControllerManager<T extends HalAbstractControll
             }
         }
 
-        // Assign the manager as a listener
+        // Assign the manager as a listener, This needs to be done every time as the controllerMap is a
-
+        // shared static for all HalControllerManagers and as we do not know if the current manager is
+        // added as listener or not we need to add it and let the implementation of addListener method
+        // handle duplicate calls.
         if (this instanceof HalDeviceReportListener)
             controller.addListener((HalDeviceReportListener) this);
 

plugins/hal-dummy/src/se/hal/plugin/dummy/DummyController.java

@@ -68,7 +68,8 @@ public class DummyController implements HalSensorController, HalEventController,
 
     @Override
     public void addListener(HalDeviceReportListener listener) {
-        deviceListeners.add(listener);
+        if (!deviceListeners.contains(listener))
+            deviceListeners.add(listener);
     }
 
     @Override

plugins/hal-mqtt/src/se/hal/plugin/mqtt/HalMqttController.java

@@ -154,6 +154,7 @@ public class HalMqttController implements HalAutostartController, MqttSubscripti
 
     @Override
     public void addListener(HalDeviceReportListener listener) {
-        deviceListeners.add(listener);
+        if (!deviceListeners.contains(listener))
+            deviceListeners.add(listener);
     }
 }

plugins/hal-netscan/src/se/hal/plugin/netscan/NetScanController.java

@@ -125,7 +125,8 @@ public class NetScanController implements HalEventController, HalAutostartContro
 
     @Override
     public void addListener(HalDeviceReportListener listener) {
-        deviceListeners.add(listener);
+        if (!deviceListeners.contains(listener))
+            deviceListeners.add(listener);
     }
 
 

plugins/hal-nutups/src/se/hal/plugin/nutups/NutUpsController.java

@@ -101,7 +101,8 @@ public class NutUpsController implements HalSensorController, HalAutostartContro
 
     @Override
     public void addListener(HalDeviceReportListener listener) {
-        deviceListeners.add(listener);
+        if (!deviceListeners.contains(listener))
+            deviceListeners.add(listener);
     }
 
 

plugins/hal-nvr/src/se/hal/plugin/nvr/rtsp/RTSPController.java

@@ -83,7 +83,8 @@ public class RTSPController implements HalCameraController {
 
     @Override
     public void addListener(HalDeviceReportListener listener) {
-        deviceListeners.add(listener);
+        if (!deviceListeners.contains(listener))
+            deviceListeners.add(listener);
     }
 
 }

plugins/hal-raspberry/src/se/hal/plugin/raspberry/RPiController.java

@@ -77,7 +77,8 @@ public class RPiController implements HalSensorController {
 
     @Override
     public void addListener(HalDeviceReportListener listener) {
-        deviceListeners.add(listener);
+        if (!deviceListeners.contains(listener))
+            deviceListeners.add(listener);
     }
 
     @Override

plugins/hal-tellstick/src/se/hal/plugin/tellstick/TellstickSerialComm.java

@@ -252,7 +252,8 @@ public class TellstickSerialComm implements Runnable,
 
     @Override
     public void addListener(HalDeviceReportListener listener) {
-        deviceListeners.add(listener);
+        if (!deviceListeners.contains(listener))
+            deviceListeners.add(listener);
     }
 
 

plugins/hal-zigbee/src/se/hal/plugin/zigbee/ZigbeeController.java

@@ -386,7 +386,8 @@ public class ZigbeeController implements HalSensorController,
 
     @Override
     public void addListener(HalDeviceReportListener listener) {
-        deviceListeners.add(listener);
+        if (!deviceListeners.contains(listener))
+            deviceListeners.add(listener);
     }
 
     @Override

plugins/hal-zwave/src/se/hal/plugin/zwave/HalZWaveController.java

@@ -321,7 +321,8 @@ public class HalZWaveController implements HalSensorController, HalEventControll
 
     @Override
     public void addListener(HalDeviceReportListener listener) {
-        deviceListeners.add(listener);
+        if (!deviceListeners.contains(listener))
+            deviceListeners.add(listener);
     }
 
 }